dtls13: add check over handshake message length#10769
Merged
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a DTLS 1.3 safety check to prevent buffering/reassembly of unauthenticated handshake fragments that claim an excessive message_length, and introduces a regression test to ensure oversized plaintext handshake messages are dropped rather than stored.
Changes:
- Add a
MAX_HANDSHAKE_SZcap check insrc/dtls13.cbefore buffering handshake fragments for reassembly. - Add a new DTLS 1.3 memio test that spoofs a plaintext
ServerHellohandshakemessage_lengthto exceedMAX_HANDSHAKE_SZand asserts nothing is buffered. - Register the new test in the DTLS API test declarations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/api/test_dtls.h |
Declares and registers the new DTLS 1.3 oversized handshake-length test. |
tests/api/test_dtls.c |
Adds a memio-based regression test that injects an oversized plaintext handshake fragment and checks it isn’t buffered. |
src/dtls13.c |
Caps DTLS 1.3 handshake messageLength prior to fragment buffering; drops oversized plaintext messages and errors on oversized encrypted ones. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rizlik
force-pushed
the
dtls13_max_handshake_sz
branch
from
June 29, 2026 11:33
0132f13 to
06a6714
Compare
rizlik
force-pushed
the
dtls13_max_handshake_sz
branch
2 times, most recently
from
July 20, 2026 08:20
3dcd90f to
028a407
Compare
julek-wolfssl
approved these changes
Jul 23, 2026
SparkiDev
approved these changes
Jul 23, 2026
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10769
Scan targets checked: wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.